Code review comment for lp:~jelmer/bzr/uncommit-remove-tags

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/24/2011 7:30 AM, Martin Pool wrote:
> Review: Approve That's good.
>
> [tweak] It's a bit safer to add new keyword parameters at the end.
>
> [tweak] Please mention it in the user guide under uncommit.

I'm a bit concerned that we do a graph search to find what tags to
remove. I guess we've only been doing a linear search to resolve what
revisions to display?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5UyAIACgkQJdeBCYSNAAPBegCfVrVDCtKFCvmBgJ7OEg7WGgWc
k8oAoNeYK5humf4yWFpI2lD+t4oh2GbX
=j8AV
-----END PGP SIGNATURE-----

« Back to merge proposal