Code review comment for lp:~jelmer/bzr/per-repository-vf

Revision history for this message
Vincent Ladeuil (vila) wrote :

148 +def load_tests(standard_tests, module, loader):
149 + scenarios = []
150 + for test_name, scenario_info in all_repository_format_scenarios():
151 + format = scenario_info['repository_format']
152 + if format.supports_full_versioned_files:
153 + scenarios.append((test_name, scenario_info))
154 + result = loader.suiteClass()
155 + tests = loader.loadTestsFromModuleNames([
156 + 'bzrlib.tests.per_repository_vf.test_repository'])
157 + multiply_tests(tests, scenarios, result)
158 + return result

Hmm, wouldn't it be better to use a scenarios attribute in test_repository.py instead of having the parametrization done in a separate file ?

I'm a bit concerned about the next dev that will try to add tests in this directory...

Other than that, ok to land.

review: Needs Fixing

« Back to merge proposal