Code review comment for lp:~jelmer/bzr/mutableinventorytree

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/11/2011 8:46 AM, Martin Pool wrote:
> This fails run on the lucid pqm, as shown below. I don't know yet if
> those are problems with pqm or with this patch; off hand it could be
> either
>
...

> from bzrlib.workingtree import _FastPath
> ImportError: cannot import name _FastPath
> 0
> ]
> time: 2011-04-11 06:28:10.817768Z
> time: 2011-04-11 06:28:10.817818Z
> test: bzrlib.tests.test_smart_add.TestAddActions.test_quiet
> time: 2011-04-11 06:28:10.819279Z
> error: bzrlib.tests.test_smart_add.TestAddActions.test_quiet [ multipart
> Content-Type: text/plain;charset=utf8
> log
> 0
> Content-Type: text/x-traceback;charset=utf8,language=python
> traceback
> 23C
> Traceback (most recent call last):
> File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
> 144, in _run_user
> return fn(*args)
> File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
> 465, in _run_test_method
> testMethod()
> File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_smart_add.py",
> line 149, in test_quiet
> self.run_action("")
> File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_smart_add.py",
> line 155, in run_action
> from bzrlib.workingtree import _FastPath
> ImportError: cannot import name _FastPath
> 0
> ]
>

That sounds like an import ordering failure, which seems pretty strange.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2isNcACgkQJdeBCYSNAAOoHQCdEYRpqc8SzWZ2uExlCPC9waoI
L+EAoMfffQWhlfvcKqv+U8LHvjjKYkp8
=Q/Zr
-----END PGP SIGNATURE-----

« Back to merge proposal