Code review comment for lp:~jelmer/bzr/merge-grep

Revision history for this message
Martin Packman (gz) wrote :

Tests now pass.

Idle query, why don't we use bzr join for things like this?

Don't like moving the colour stuff to bzrlib.termcolor, it's not the interface I think we'll want to be supporting in core long term. Can stick it back under grep or rename to _termcolor so it's clear we don't want other plugins basing output off this interface.

Looks good apart from that.

review: Approve

« Back to merge proposal