Looks fine, though unlikely to have a big impact.
Seems like _register_hooks should be replaced with a install_lazy_named_hook call, which would mean the _mod_branch import could go as well?
# Since we are a built-in plugin we share the bzrlib version + trace, version_info,
Addition split the comment from the version_info line it's talking about. Mixing up module and object imports is a bit ick, but that's python.
« Back to merge proposal
Looks fine, though unlikely to have a big impact.
Seems like _register_hooks should be replaced with a install_ lazy_named_ hook call, which would mean the _mod_branch import could go as well?
# Since we are a built-in plugin we share the bzrlib version
+ trace,
version_info,
Addition split the comment from the version_info line it's talking about. Mixing up module and object imports is a bit ick, but that's python.