Code review comment for lp:~jelmer/bzr/info-shows-colocated-branches

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Thanks for the review. :-)
>
> > 12 + outfile.write('Control directory:\n')
> > 13 + outfile.write(' %d branches\n' % len(control.list_branches()))
> >
> > Do we really want to mention 'Control directory' to our users ? I'm +1 for
> > adding the _show_control_dir_info() so we have a single place for everything
> > related to the control dir that is not already covered by the other
> functions,
> > but I'm less convinced that we should tell our users about it...
> >
> > I don't have a good alternative to propose so I won't block on it though.
> We only print this if there is a bare control directory present, without a
> repository, branch or working tree. I think we should tell the user
> *something* in this case - previously we were not outputting anything at all.
Scratch that, wrong MP! Sorry.

« Back to merge proposal