Code review comment for lp:~jelmer/bzr/info-shows-colocated-branches

Revision history for this message
Vincent Ladeuil (vila) wrote :

12 + outfile.write('Control directory:\n')
13 + outfile.write(' %d branches\n' % len(control.list_branches()))

Urgh, what a weird indendation ! Even lp removed the spaces before '%d' when I pasted the line above...

Yeah, I realise this is *required* to align with the 'Branch history' and 'Repository' lines, just wanted to let you know I share the feeling (if not with you, at least with lp ;)

Yet, Riddell showed us how to handle plural form for the above, care to fix that ?

Ha crap, nothing in the command have been localized yet, forget about that :-/

Do we really want to mention 'Control directory' to our users ? I'm +1 for adding the _show_control_dir_info() so we have a single place for everything related to the control dir that is not already covered by the other functions, but I'm less convinced that we should tell our users about it...

I don't have a good alternative to propose so I won't block on it though.

review: Approve

« Back to merge proposal