Code review comment for lp:~jelmer/bzr/import-tariff-test-case

Revision history for this message
Vincent Ladeuil (vila) wrote :

[needsfixing] If ImportTariffTestCase is the preferred way to add such tests for plugins the doc string should stay there I think.

[thinking out loud] There are several places where this class may be defined: in test_import_tariff, in tests itself or in tests.fixtures.

tests itself sounds to broad for such focused tests and we don't have test classes in fixtures (and that may not be a good fit either).

I'll tend to leave the class in test_import_tariff.

review: Needs Fixing

« Back to merge proposal