Merge lp:~jelmer/bzr/fix-en-use-guide into lp:bzr

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Richard Wilbur
Approved revision: no longer in the source branch.
Merged at revision: 6617
Proposed branch: lp:~jelmer/bzr/fix-en-use-guide
Merge into: lp:bzr
Diff against target: 26 lines (+5/-1)
2 files modified
Makefile (+1/-1)
doc/en/release-notes/bzr-2.8.txt (+4/-0)
To merge this branch: bzr merge lp:~jelmer/bzr/fix-en-use-guide
Reviewer Review Type Date Requested Status
Richard Wilbur Approve
Vincent Ladeuil Approve
Review via email: mp+290831@code.launchpad.net

Commit message

Ensure build of English use guide always uses English text even when user's locale specifies a different language.

Description of the change

Simple fix to prevent French text from leaking into English user reference.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

Nice catch !

review: Approve
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Thanks, Jelmer, for finding the bug and the concise fix!
+1

review: Approve
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2016-02-01 18:09:33 +0000
+++ Makefile 2016-04-03 16:44:55 +0000
@@ -148,7 +148,7 @@
148NEWS_FILES = $(wildcard doc/en/release-notes/bzr-*.txt)148NEWS_FILES = $(wildcard doc/en/release-notes/bzr-*.txt)
149149
150doc/en/user-reference/index.txt: $(MAN_DEPENDENCIES)150doc/en/user-reference/index.txt: $(MAN_DEPENDENCIES)
151 $(PYTHON) tools/generate_docs.py -o $@ rstx151 LANGUAGE=C $(PYTHON) tools/generate_docs.py -o $@ rstx
152152
153doc/en/release-notes/index.txt: $(NEWS_FILES) tools/generate_release_notes.py153doc/en/release-notes/index.txt: $(NEWS_FILES) tools/generate_release_notes.py
154 $(PYTHON) tools/generate_release_notes.py $@ $(NEWS_FILES)154 $(PYTHON) tools/generate_release_notes.py $@ $(NEWS_FILES)
155155
=== modified file 'doc/en/release-notes/bzr-2.8.txt'
--- doc/en/release-notes/bzr-2.8.txt 2016-02-01 19:26:41 +0000
+++ doc/en/release-notes/bzr-2.8.txt 2016-04-03 16:44:55 +0000
@@ -32,6 +32,10 @@
32.. Fixes for situations where bzr would previously crash or give incorrect32.. Fixes for situations where bzr would previously crash or give incorrect
33 or undesirable results.33 or undesirable results.
3434
35 * When generating documentation with a custom locale set, make sure
36 doc/en/user-reference only contains English documentation.
37 (Jelmer Vernooij, #1565503)
38
35Documentation39Documentation
36*************40*************
3741