Code review comment for lp:~jelmer/bzr/diff-git

On Mon, 2010-12-20 at 12:41 +0000, Vincent Ladeuil wrote:
> Review: Abstain
> I'm not a big fan of format_switches either :-/
>
> On the other hand either we should stop using them or not object when they *can* be used...
>
> But for your current issue, why don't you just use "bzr alias diff-git='bzr diff --format=git" ?
>
> This will save you 2 keystrokes by invocation so the definition should be amortized with as little as 21 uses ;)
Bazaar should have good usability out of the box as much as possible. As
this is something that would affect other users too I'm wary of working
around it with a local alias.

There are two issues with --format=git:

* it's not discoverable
* it's not very short

Having "bzr git --diff" is one way of addressing those. Perhaps there
are better alternatives (see my other reply).

Cheers,

Jelmer