Code review comment for lp:~jelmer/bzr/config-file-permdenied

Revision history for this message
Vincent Ladeuil (vila) wrote :

> On 08/31/2011 01:27 AM, Martin [gz] wrote:
> > Again, this results in mangled path on non-utf-8 terminals.
> I think that's a separate issue we need to address. trace is defined as
> using utf8 at the moment so this is the only sensible thing to do right now.

I agree with mgz that encoding issues need to be addressed too ;)

I agree with jelmer that we need to go forward there ;)

@mgz: Is there a bug tracking this particular issue ?

I want my cake and eat it too: this fix addresses a specific
issue in a highly unsual env which deserves a better *error*
reporting, i.e.: something is already wrong in the setup.

If this env *also* provides a broken terminal, well, I don't mind
giving a mangled path until we are able to give a meaningful
one. If trying to report this error *fails*, then that's more
concerning, but 'mangled', I can live with that (for now ;).

Summary: I think we shouldn't block here. mgz, is that ok ?

« Back to merge proposal