Code review comment for lp:~jelmer/bzr/bzr.1-generate-environment-section

Revision history for this message
Martin Packman (gz) wrote :

I like the idea of making it a 3-tuple with set([None, 'posix', 'nt']) for defining bit and displaying only if `t[2] in (None, os.name)` or similar.

Some mini tests for the layout function?

+ ret.append("=" * max_key_len + " " + "=" * desc_len + "\n")
...
+ ret += "=" * max_key_len + " " + "=" * desc_len + "\n"

One of these lines is not like the other. So, which adds one string of 80 characters, and which adds 80 strings of one character? :)

« Back to merge proposal