Code review comment for lp:~jelmer/bzr/branchfmt

> I'm not sure I understand the purpose of the proposal here, it seems like a
> step towards... something I can't put my finger on ;)
>
> Should branchfmt be named branch_old_formats_you_should_ngot_use_anymore ?
No, as I can imagine us moving other branch formats in there in the future as well.

> If not, what kind of modules will be added there ? When ?
I would imagine adding new formats there in the future if we have a good reason to. We could add the existing formats there too, e.g. in bzrlib.branchfmt.revinfo or something like that (since they store just the revinfo tuple rather than full history).

> No objection per se but I've got the feeling we don't use the right names here
> nor put this code in the right place.
>
> I think I would feel more comfortable if this code could be handled in the
> same way the weave code was but if it's too early for that may be we should
> just wait.
The weave branch format already lives in bzrlib/plugins/weave. This is just about putting the various branch formats in separate files (like bzrlib.repofmt), rather than in bzrlib.branch where it is always loaded.