Code review comment for lp:~jelmer/bzr-builder/pristine-tar-upstream

Revision history for this message
James Westby (james-w) wrote :

On Mon, 06 Jun 2011 16:57:29 -0000, Jelmer Vernooij <email address hidden> wrote:
> > 148 +def reconstruct_pristine_tar(dest, delta, dest_filename):
> >
> > I guessed that these were going to come from the code you split out in bzr-builddeb.
> > Was that the intention?
> That was my original intention but it turned out to be a really trivial
> function in the end and it could even be made shorter by using the
> _run_command utility function in bzr-builder.

Should we move _run_command to bzr-builddeb and make it smaller there
and re-use it here?

Are there drawbacks to depending on bzr-builddeb?

Thanks,

James

« Back to merge proposal