Code review comment for lp:~jelmer/bzr-builder/pristine-tar-upstream

On Mon, 2011-06-06 at 16:19 +0000, James Westby wrote:
> Thanks for doing this!
My pleasure :) This should means that at least these things are out of
the way when there's some developer time available to work on the
Launchpad side of build-from-branch-into-ppa/primary.

> 81 - version = base_branch.deb_version
> 82 - if "-" in version:
> 83 - version = version[:version.rindex("-")]
> 84 - package_basedir = "%s-%s" % (package_name, version)
> 85 + package_basedir = "%s-%s" % (package_name, package_version.upstream_version)
>
> This does actually change behaviour if the version has an epoch, is that ok?
Yep, that's fine - though that's a good catch, I hadn't considered it
earlier.

> 148 +def reconstruct_pristine_tar(dest, delta, dest_filename):
>
> I guessed that these were going to come from the code you split out in bzr-builddeb.
> Was that the intention?
That was my original intention but it turned out to be a really trivial
function in the end and it could even be made shorter by using the
_run_command utility function in bzr-builder.

Cheers,

Jelmer