Code review comment for lp:~jelmer/bzr-builddeb/pre-commit-quilt

Revision history for this message
James Westby (james-w) wrote :

Hi,

This looks good, and is nice and small.

I'm not sure about the default behaviour though.

As it stands we expect all patches to be applied in the importer, so
doing anything else is wrong for udd. Perhaps we don't want to enforce
that, but this will warn if someone is doing the right thing, and won't
warn if they have all the patches unapplied.

I'm not sure what the default behaviour should be, but do you agree that
this warning will confuse people?

Thanks,

James

« Back to merge proposal