Code review comment for lp:~jelmer/bzr-builddeb/newlplib

On Fri, 04 Mar 2011 19:06:17 -0000, Jelmer Vernooij <email address hidden> wrote:
> > This change doesn't preserve this existing behaviour.
> >
> > 22 + if not os.path.exists(creds_path):
> > 23 + return None
> >
> > Maybe we don't want that any more, but if not we should
> > drop it from both code paths.
> In what way is that incompatible? Because we'll now perhaps prompt the user to log in ?

Yeah. IIRC this was done so that you had to explicitly configure it, as
I didn't want to prompt everyone for credentials when this is a feature
that won't have any effect in the vast majority of cases, except for the
importer.

> I guess we could use "Launchpad.login_anonymously" as an alternative.

That would at least avoid the prompt wouldn't it? I'm still not sure it
is worth the round trips, given that the feature is mainly useful for
the importer.

Thanks,

James