Merge lp:~jelmer/bzr-builddeb/import-dsc-tarball-imports into lp:bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Approved by: James Westby
Approved revision: 592
Merged at revision: 593
Proposed branch: lp:~jelmer/bzr-builddeb/import-dsc-tarball-imports
Merge into: lp:bzr-builddeb
Diff against target: 46 lines (+14/-3)
2 files modified
import_dsc.py (+6/-3)
tests/test_import_dsc.py (+8/-0)
To merge this branch: bzr merge lp:~jelmer/bzr-builddeb/import-dsc-tarball-imports
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+68549@code.launchpad.net

Description of the change

Fix importing upstream tarballs from 3.0 (quilt) packages in "bzr import-dsc".

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'import_dsc.py'
--- import_dsc.py 2011-07-17 13:32:31 +0000
+++ import_dsc.py 2011-07-20 14:12:39 +0000
@@ -1513,9 +1513,12 @@
1513 "0000", "-exec", "chmod", "644", "{}", ";"])1513 "0000", "-exec", "chmod", "644", "{}", ";"])
1514 for part in self.dsc['files']:1514 for part in self.dsc['files']:
1515 if part['name'].startswith("%s_%s.orig" % (name, str(version.upstream_version))):1515 if part['name'].startswith("%s_%s.orig" % (name, str(version.upstream_version))):
1516 self.upstream_tarballs.append((os.path.abspath(1516 self.upstream_tarballs.append((
1517 os.path.join(osutils.dirname(self.dsc_path),1517 os.path.abspath(os.path.join(osutils.dirname(self.dsc_path),
1518 part['name'])), part['md5sum']))1518 part['name'])),
1519 component_from_orig_tarball(part['name'], name,
1520 str(version.upstream_version)),
1521 part['md5sum']))
1519 elif (part['name'].endswith(".debian.tar.gz")1522 elif (part['name'].endswith(".debian.tar.gz")
1520 or part['name'].endswith(".debian.tar.bz2")1523 or part['name'].endswith(".debian.tar.bz2")
1521 or part['name'].endswith(".debian.tar.lzma")):1524 or part['name'].endswith(".debian.tar.lzma")):
15221525
=== modified file 'tests/test_import_dsc.py'
--- tests/test_import_dsc.py 2011-07-17 12:12:25 +0000
+++ tests/test_import_dsc.py 2011-07-20 14:12:39 +0000
@@ -1849,7 +1849,11 @@
1849 "README")))1849 "README")))
1850 self.assertFalse(os.path.exists(os.path.join(orig_dir,1850 self.assertFalse(os.path.exists(os.path.join(orig_dir,
1851 "debian", "control")))1851 "debian", "control")))
1852 self.assertEquals(1, len(extractor.upstream_tarballs))
1853 self.assertEquals(3, len(extractor.upstream_tarballs[0]))
1852 self.assertTrue(os.path.exists(extractor.upstream_tarballs[0][0]))1854 self.assertTrue(os.path.exists(extractor.upstream_tarballs[0][0]))
1855 self.assertIs(None, extractor.upstream_tarballs[0][1])
1856 self.assertIsInstance(extractor.upstream_tarballs[0][2], unicode) # md5sum
1853 finally:1857 finally:
1854 extractor.cleanup()1858 extractor.cleanup()
18551859
@@ -1930,7 +1934,11 @@
1930 "README")))1934 "README")))
1931 self.assertFalse(os.path.exists(os.path.join(orig_dir,1935 self.assertFalse(os.path.exists(os.path.join(orig_dir,
1932 "debian", "control")))1936 "debian", "control")))
1937 self.assertEquals(1, len(extractor.upstream_tarballs))
1938 self.assertEquals(3, len(extractor.upstream_tarballs[0]))
1933 self.assertTrue(os.path.exists(extractor.upstream_tarballs[0][0]))1939 self.assertTrue(os.path.exists(extractor.upstream_tarballs[0][0]))
1940 self.assertIs(None, extractor.upstream_tarballs[0][1])
1941 self.assertIsInstance(extractor.upstream_tarballs[0][2], unicode) # md5sum
1934 finally:1942 finally:
1935 extractor.cleanup()1943 extractor.cleanup()
19361944

Subscribers

People subscribed via source and target branches