Merge lp:~jelmer/bzr-builddeb/git-fixes into lp:bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 735
Proposed branch: lp:~jelmer/bzr-builddeb/git-fixes
Merge into: lp:bzr-builddeb
Diff against target: 36 lines (+4/-2)
3 files modified
debian/changelog (+1/-0)
source_distiller.py (+1/-1)
util.py (+2/-1)
To merge this branch: bzr merge lp:~jelmer/bzr-builddeb/git-fixes
Reviewer Review Type Date Requested Status
Bzr-builddeb-hackers Pending
Review via email: mp+133170@code.launchpad.net

Description of the change

Some improvements for using bzr-builddeb on git branches.

- Don't consider .gitignore when looking for upstream sources
- Use Tree.iter_entries_by_dir() rather than Tree.inventory.iter_entries(); e.g. Git Tree implementations don't have inventories.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

review: approve

John
=:->
On Nov 7, 2012 6:10 AM, "Jelmer Vernooij" <email address hidden> wrote:

> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-builddeb/git-fixes
> into lp:bzr-builddeb.
>
> Requested reviews:
> Bzr-builddeb-hackers (bzr-builddeb-hackers)
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-builddeb/git-fixes/+merge/133170
>
> Some improvements for using bzr-builddeb on git branches.
>
> - Don't consider .gitignore when looking for upstream sources
> - Use Tree.iter_entries_by_dir() rather than
> Tree.inventory.iter_entries(); e.g. Git Tree implementations don't have
> inventories.
> --
> https://code.launchpad.net/~jelmer/bzr-builddeb/git-fixes/+merge/133170
> You are subscribed to branch lp:bzr-builddeb.
>
> === modified file 'debian/changelog'
> --- debian/changelog 2012-09-06 23:25:29 +0000
> +++ debian/changelog 2012-11-07 02:09:18 +0000
> @@ -2,6 +2,7 @@
>
> * Cope with quilt output being empty in error message. LP: #1014543
> * Remove myself from uploaders.
> + * Don't consider .gitignore when looking for upstream sources.
>
> -- Jelmer Vernooij <email address hidden> Mon, 09 Jul 2012 12:04:50 +0200
>
>
> === modified file 'source_distiller.py'
> --- source_distiller.py 2012-01-02 22:02:47 +0000
> +++ source_distiller.py 2012-11-07 02:09:18 +0000
> @@ -83,7 +83,7 @@
> raise NotImplementedError(self._distill)
>
> def _prepare_working_tree(self):
> - for (dp, ie) in self.tree.inventory.iter_entries():
> + for (dp, ie) in self.tree.iter_entries_by_dir():
> ie._read_tree_state(dp, self.tree)
>
>
>
> === modified file 'util.py'
> --- util.py 2012-02-01 16:35:53 +0000
> +++ util.py 2012-11-07 02:09:18 +0000
> @@ -673,7 +673,8 @@
> if f[1] == 'V'])
> if len(present_files) == 0:
> return None
> - packaging_files = frozenset(["debian", ".bzr-builddeb", ".bzrignore"])
> + packaging_files = frozenset([
> + "debian", ".bzr-builddeb", ".bzrignore", ".gitignore"])
> return (len(present_files - packaging_files) > 0)
>
>
>
>
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-09-06 23:25:29 +0000
+++ debian/changelog 2012-11-07 02:09:18 +0000
@@ -2,6 +2,7 @@
22
3 * Cope with quilt output being empty in error message. LP: #10145433 * Cope with quilt output being empty in error message. LP: #1014543
4 * Remove myself from uploaders.4 * Remove myself from uploaders.
5 * Don't consider .gitignore when looking for upstream sources.
56
6 -- Jelmer Vernooij <jelmer@debian.org> Mon, 09 Jul 2012 12:04:50 +02007 -- Jelmer Vernooij <jelmer@debian.org> Mon, 09 Jul 2012 12:04:50 +0200
78
89
=== modified file 'source_distiller.py'
--- source_distiller.py 2012-01-02 22:02:47 +0000
+++ source_distiller.py 2012-11-07 02:09:18 +0000
@@ -83,7 +83,7 @@
83 raise NotImplementedError(self._distill)83 raise NotImplementedError(self._distill)
8484
85 def _prepare_working_tree(self):85 def _prepare_working_tree(self):
86 for (dp, ie) in self.tree.inventory.iter_entries():86 for (dp, ie) in self.tree.iter_entries_by_dir():
87 ie._read_tree_state(dp, self.tree)87 ie._read_tree_state(dp, self.tree)
8888
8989
9090
=== modified file 'util.py'
--- util.py 2012-02-01 16:35:53 +0000
+++ util.py 2012-11-07 02:09:18 +0000
@@ -673,7 +673,8 @@
673 if f[1] == 'V'])673 if f[1] == 'V'])
674 if len(present_files) == 0:674 if len(present_files) == 0:
675 return None675 return None
676 packaging_files = frozenset(["debian", ".bzr-builddeb", ".bzrignore"])676 packaging_files = frozenset([
677 "debian", ".bzr-builddeb", ".bzrignore", ".gitignore"])
677 return (len(present_files - packaging_files) > 0)678 return (len(present_files - packaging_files) > 0)
678679
679680

Subscribers

People subscribed via source and target branches