Merge lp:~jelmer/bzr-builddeb/get-export-upstream-revision-version into lp:bzr-builddeb
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | 495 |
Merged at revision: | 496 |
Proposed branch: | lp:~jelmer/bzr-builddeb/get-export-upstream-revision-version |
Merge into: | lp:bzr-builddeb |
Diff against target: |
72 lines (+10/-10) 3 files modified
cmds.py (+2/-2) tests/test_util.py (+4/-4) util.py (+4/-4) |
To merge this branch: | bzr merge lp:~jelmer/bzr-builddeb/get-export-upstream-revision-version |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Approve | ||
Review via email: mp+47208@code.launchpad.net |
Description of the change
Some trivial refactoring to make get_export_
This is required for the fix of bug 295274.
To post a comment you must log in.
Hi,
Looks ok, but I might like an assert here similar to the ones you added when
we made similar changes elsewhere. It's easy to get the type wrong and
because Version defines __str__ get the wrong results. What do you think?
Thanks,
James