Code review comment for lp:~jelmer/bzr-builddeb/fix-restart

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

On Sun, 2010-04-11 at 22:18 +0000, Robert Collins wrote:
> Review: Approve
> review: +1
>
> Oh, argh, I see the issue - perhaps. Is the case you're dealing with
> that the second getattr is looked up before the first, as its passed
> into the first/outer one, so the compatability code only works one way
> at the moment?
Yep, that's indeed what I intended to fix. The author probably had the
function in the second getattr present so never saw the AttributeError,
as the first getattr has three arguments and never raises
AttributeError.

Cheers,

Jelmer

« Back to merge proposal