Code review comment for lp:~jelmer/bzr-builddeb/auto-native

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi,

Thanks for the review :-)

On Thu, 2011-01-13 at 17:58 +0000, James Westby wrote:
> On Tue, 11 Jan 2011 00:36:09 -0000, Jelmer Vernooij <email address hidden> wrote:
> > Related to this I wonder if we can drop the --native and --merge flags, they no longer seem necessary now.
> For --native there will still be a bunch of 1.0 native packages that
> this won't get.
The version is also used as an indication of whether the package is
native or not, and should work for 1.0 packages too.

> Having said that, I would like to get rid of them anyway, as there are
> some people that don't create the configuration files, and only use the
> flags, meaning that other people find problems when they try and build
> the packages.
>
> I think that we should probably have a deprecation period though.
Yeah, that makes sense.

Cheers,

Jelmer

« Back to merge proposal