Merge lp:~jelmer/brz/no-more-ie-revision into lp:brz

[Jelmer Vernooij]

Don't require that entries returned from Tree have a .revision attribute set.

If callers care, they can use Tree.get_file_revision().

Git doesn't store file revisions, and getting at this attribute is costly.

(Nothing else in the non-bzr bit of the breezy codebase currently seems to require .revision)

[Martin Packman (gz)]

Thanks.

review: Approve

[Jelmer Vernooij (jelmer)]

review: Approve

=== modified file 'breezy/tests/per_tree/test_test_trees.py'
--- breezy/tests/per_tree/test_test_trees.py	2018-03-24 13:28:54 +0000
+++ breezy/tests/per_tree/test_test_trees.py	2018-03-24 15:37:33 +0000
@@ -394,14 +394,6 @@
                 self.assertEqual(eparent, ie.parent_id)
             if eparent is not None:
                 self.assertIsInstance(ie.parent_id, bytes)
-            # WorkingTree's return None for the last modified revision
-            if ie.revision is not None:
-                self.assertIsInstance(ie.revision, str)
-                if epath == '':
-                    # Some trees will preserve the revision id of the tree root,
-                    # but not all will
-                    continue
-                self.assertEqual(erev, ie.revision)
         self.assertEqual(len(path_and_ids), len(path_entries),
                          "%r vs %r" % (
                              [p for (p, f, pf, r) in path_and_ids],