Merge lp:~jelmer/brz/fastimport-fix-2 into lp:brz/3.0

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/fastimport-fix-2
Merge into: lp:brz/3.0
Diff against target: 30 lines (+4/-4)
2 files modified
breezy/plugins/fastimport/processors/generic_processor.py (+1/-4)
doc/en/release-notes/brz-3.0.txt (+3/-0)
To merge this branch: bzr merge lp:~jelmer/brz/fastimport-fix-2
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+376208@code.launchpad.net

Commit message

fastimport: Drop unused mode flag, use standard transport.

Description of the change

Drop unused mode flag, use standard transport.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'breezy/plugins/fastimport/processors/generic_processor.py'
--- breezy/plugins/fastimport/processors/generic_processor.py 2018-11-18 19:16:07 +0000
+++ breezy/plugins/fastimport/processors/generic_processor.py 2019-12-01 16:55:55 +0000
@@ -202,12 +202,9 @@
202202
203 def _load_info_and_params(self):203 def _load_info_and_params(self):
204 from .. import bzr_commit_handler204 from .. import bzr_commit_handler
205 self._mode = bool(self.params.get('mode', 'default'))
206 self._experimental = self._mode == 'experimental'
207
208 # This is currently hard-coded but might be configurable via205 # This is currently hard-coded but might be configurable via
209 # parameters one day if that's needed206 # parameters one day if that's needed
210 repo_transport = self.repo.control_files._transport207 repo_transport = self.repo.control_transport
211 self.id_map_path = repo_transport.local_abspath("fastimport-id-map")208 self.id_map_path = repo_transport.local_abspath("fastimport-id-map")
212209
213 # Load the info file, if any210 # Load the info file, if any
214211
=== modified file 'doc/en/release-notes/brz-3.0.txt'
--- doc/en/release-notes/brz-3.0.txt 2019-11-19 17:16:42 +0000
+++ doc/en/release-notes/brz-3.0.txt 2019-12-01 16:55:55 +0000
@@ -32,6 +32,9 @@
32.. Fixes for situations where brz would previously crash or give incorrect32.. Fixes for situations where brz would previously crash or give incorrect
33 or undesirable results.33 or undesirable results.
3434
35 * Don't rely on private transport attribute in fast-import.
36 (Jelmer Vernooij, #1854607)
37
35Documentation38Documentation
36*************39*************
3740

Subscribers

People subscribed via source and target branches