Merge lp:~jelmer/brz/bad-fs-python3 into lp:brz
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merge reported by: | The Breezy Bot |
Merged at revision: | not available |
Proposed branch: | lp:~jelmer/brz/bad-fs-python3 |
Merge into: | lp:brz |
Diff against target: |
75 lines (+22/-4) 3 files modified
breezy/bzr/workingtree.py (+9/-1) breezy/osutils.py (+7/-3) python3.passing (+6/-0) |
To merge this branch: | bzr merge lp:~jelmer/brz/bad-fs-python3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman | Approve | ||
Review via email: mp+353749@code.launchpad.net |
Commit message
Fix bad fs encoding tests on python 3.
Description of the change
Fix bad fs encoding tests on python 3.
When calling os.listdir(), pass in a bytestring for the filename.
When passing in a unicode string, and if sys.getfilesyte
To post a comment you must log in.
Not sure about this, on Windows (and -ish on Macs) we're better off using unicode for filesystem operations, it's nix that gets into a mess with surrogateescape due to really being bytes underneath.