Code review comment for lp:~jelmer/brz/bad-fs-python3

Martin Packman (gz) wrote :

Okay, I think this code is wrong in several circumstances, but:

1) There is a windows specific dirreader already at least
2) Fixing it should probably replace the interfaces with something better anyway

So, lets land, and follow up separately to work out some better cross-platform filesystem abstractions despite the mess that Python 3 made of this.

review: Approve

« Back to merge proposal