Merge lp:~jeffmarcom/opencompute/remove_launchpad_prompt into lp:opencompute/checkbox

Proposed by Jeff Marcom
Status: Merged
Approved by: Jeff Lane 
Approved revision: 2166
Merged at revision: 2165
Proposed branch: lp:~jeffmarcom/opencompute/remove_launchpad_prompt
Merge into: lp:opencompute/checkbox
Diff against target: 62 lines (+9/-4)
5 files modified
debian/changelog (+2/-1)
examples/checkbox-ocp-cli.ini (+1/-1)
examples/checkbox-ocp-gtk.ini (+4/-0)
examples/checkbox-ocp-qt.ini (+1/-1)
examples/checkbox-ocp-urwid.ini (+1/-1)
To merge this branch: bzr merge lp:~jeffmarcom/opencompute/remove_launchpad_prompt
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+188930@code.launchpad.net

Commit message

Removes inappropriate launchpad submission prompt after all tests have completed.

Description of the change

This simply removes the launchpad prompt after checkbox has completed a run.

We may decided to changed the default submission location in the future while still using the plugin's functionality albeit under a different name.

For right now it's not appropriate for the project as there is no submission location.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks reasonable to me...

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

Now for the tarmac rejection! Here comes the pain.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-09-30 19:07:27 +0000
+++ debian/changelog 2013-10-02 21:05:48 +0000
@@ -6,6 +6,7 @@
6 * Updated checkbox OCP intro prompt6 * Updated checkbox OCP intro prompt
7 * Updated Open Compute ready whitelist with new power management, cpu stress, and networking tests"7 * Updated Open Compute ready whitelist with new power management, cpu stress, and networking tests"
8 * Added 12hr idle verification test and sylog check for PCI/Device errors8 * Added 12hr idle verification test and sylog check for PCI/Device errors
9 * Removed launchpad prompt
910
10 [ Jeff Lane ]11 [ Jeff Lane ]
11 * Updated OCP Checkbox to latest checkbox trunk, 0.16.11 revno 235312 * Updated OCP Checkbox to latest checkbox trunk, 0.16.11 revno 2353
@@ -15,7 +16,7 @@
15 * debian/control: promoted several packages from suggest to depends to ensure16 * debian/control: promoted several packages from suggest to depends to ensure
16 they are installed along with checkbox-ocp (LP: #1233333)17 they are installed along with checkbox-ocp (LP: #1233333)
1718
18 -- Jeff Marcom <jeff.marcom@canonical.com> Mon, 23 Sep 2013 10:13:04 -040019 -- Jeff Marcom <jeff.marcom@canonical.com> Wed, 2 Oct 2013 10:13:04 -0400
1920
20checkbox (1.16.6~OCP) UNRELEASED; urgency=low21checkbox (1.16.6~OCP) UNRELEASED; urgency=low
2122
2223
=== modified file 'examples/checkbox-ocp-cli.ini'
--- examples/checkbox-ocp-cli.ini 2013-09-24 03:06:31 +0000
+++ examples/checkbox-ocp-cli.ini 2013-10-02 21:05:48 +0000
@@ -14,4 +14,4 @@
1414
15[checkbox/plugins]15[checkbox/plugins]
1616
17blacklist = hexr_prompt hexr_transport17blacklist = hexr_prompt hexr_transport launchpad_prompt
1818
=== modified file 'examples/checkbox-ocp-gtk.ini'
--- examples/checkbox-ocp-gtk.ini 2013-09-24 03:06:31 +0000
+++ examples/checkbox-ocp-gtk.ini 2013-10-02 21:05:48 +0000
@@ -14,3 +14,7 @@
1414
15# Path where GTK files are stored.15# Path where GTK files are stored.
16data_path = %(checkbox_share)s/gtk16data_path = %(checkbox_share)s/gtk
17
18[checkbox/plugins]
19
20blacklist = hexr_prompt hexr_transport launchpad_prompt
1721
=== modified file 'examples/checkbox-ocp-qt.ini'
--- examples/checkbox-ocp-qt.ini 2013-09-24 03:06:31 +0000
+++ examples/checkbox-ocp-qt.ini 2013-10-02 21:05:48 +0000
@@ -17,4 +17,4 @@
1717
18[checkbox/plugins]18[checkbox/plugins]
1919
20blacklist = hexr_prompt hexr_transport20blacklist = hexr_prompt hexr_transport launchpad_prompt
2121
=== modified file 'examples/checkbox-ocp-urwid.ini'
--- examples/checkbox-ocp-urwid.ini 2013-09-24 03:06:31 +0000
+++ examples/checkbox-ocp-urwid.ini 2013-10-02 21:05:48 +0000
@@ -14,4 +14,4 @@
1414
15[checkbox/plugins]15[checkbox/plugins]
1616
17blacklist = hexr_prompt hexr_transport17blacklist = hexr_prompt hexr_transport launchpad_prompt

Subscribers

People subscribed via source and target branches