The Open Compute Project

Merge lp:~jeffmarcom/opencompute/remove_launchpad_prompt into lp:opencompute/checkbox

  1. remove_launchpad_prompt
  2. Merge into checkbox
Proposed by Jeff Marcom
Status: Merged
Approved by: Jeff Lane 
Approved revision: 2166
Merged at revision: 2165
Proposed branch: lp:~jeffmarcom/opencompute/remove_launchpad_prompt
Merge into: lp:opencompute/checkbox
Diff against target: 62 lines (+9/-4)
5 files modified
debian/changelog (+2/-1)
examples/checkbox-ocp-cli.ini (+1/-1)
examples/checkbox-ocp-gtk.ini (+4/-0)
examples/checkbox-ocp-qt.ini (+1/-1)
examples/checkbox-ocp-urwid.ini (+1/-1)
To merge this branch: bzr merge lp:~jeffmarcom/opencompute/remove_launchpad_prompt
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+188930@code.launchpad.net

Commit message

Removes inappropriate launchpad submission prompt after all tests have completed.

Description of the change

This simply removes the launchpad prompt after checkbox has completed a run.

We may decided to changed the default submission location in the future while still using the plugin's functionality albeit under a different name.

For right now it's not appropriate for the project as there is no submission location.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks reasonable to me...

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

Now for the tarmac rejection! Here comes the pain.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-09-30 19:07:27 +0000
3+++ debian/changelog 2013-10-02 21:05:48 +0000
4@@ -6,6 +6,7 @@
5 * Updated checkbox OCP intro prompt
6 * Updated Open Compute ready whitelist with new power management, cpu stress, and networking tests"
7 * Added 12hr idle verification test and sylog check for PCI/Device errors
8+ * Removed launchpad prompt
9
10 [ Jeff Lane ]
11 * Updated OCP Checkbox to latest checkbox trunk, 0.16.11 revno 2353
12@@ -15,7 +16,7 @@
13 * debian/control: promoted several packages from suggest to depends to ensure
14 they are installed along with checkbox-ocp (LP: #1233333)
15
16- -- Jeff Marcom <jeff.marcom@canonical.com> Mon, 23 Sep 2013 10:13:04 -0400
17+ -- Jeff Marcom <jeff.marcom@canonical.com> Wed, 2 Oct 2013 10:13:04 -0400
18
19 checkbox (1.16.6~OCP) UNRELEASED; urgency=low
20
21
22=== modified file 'examples/checkbox-ocp-cli.ini'
23--- examples/checkbox-ocp-cli.ini 2013-09-24 03:06:31 +0000
24+++ examples/checkbox-ocp-cli.ini 2013-10-02 21:05:48 +0000
25@@ -14,4 +14,4 @@
26
27 [checkbox/plugins]
28
29-blacklist = hexr_prompt hexr_transport
30+blacklist = hexr_prompt hexr_transport launchpad_prompt
31
32=== modified file 'examples/checkbox-ocp-gtk.ini'
33--- examples/checkbox-ocp-gtk.ini 2013-09-24 03:06:31 +0000
34+++ examples/checkbox-ocp-gtk.ini 2013-10-02 21:05:48 +0000
35@@ -14,3 +14,7 @@
36
37 # Path where GTK files are stored.
38 data_path = %(checkbox_share)s/gtk
39+
40+[checkbox/plugins]
41+
42+blacklist = hexr_prompt hexr_transport launchpad_prompt
43
44=== modified file 'examples/checkbox-ocp-qt.ini'
45--- examples/checkbox-ocp-qt.ini 2013-09-24 03:06:31 +0000
46+++ examples/checkbox-ocp-qt.ini 2013-10-02 21:05:48 +0000
47@@ -17,4 +17,4 @@
48
49 [checkbox/plugins]
50
51-blacklist = hexr_prompt hexr_transport
52+blacklist = hexr_prompt hexr_transport launchpad_prompt
53
54=== modified file 'examples/checkbox-ocp-urwid.ini'
55--- examples/checkbox-ocp-urwid.ini 2013-09-24 03:06:31 +0000
56+++ examples/checkbox-ocp-urwid.ini 2013-10-02 21:05:48 +0000
57@@ -14,4 +14,4 @@
58
59 [checkbox/plugins]
60
61-blacklist = hexr_prompt hexr_transport
62+blacklist = hexr_prompt hexr_transport launchpad_prompt

Subscribers

People subscribed via source and target branches