The Open Compute Project

Code review comment for lp:~jeffmarcom/opencompute/cleanup_of_ipmi_oob_jobs

  1. cleanup_of_ipmi_oob_jobs
  2. Merge into checkbox
Revision history for this message
Jeff Lane  (bladernr) wrote :

I noticed you modified POTFILES.in but in the ipmi_out_of_band.txt.in file, none of the jobs have translatable strings... you need to specify that like so:

_description:
 Some string here

the version in changelot is now 0.16.6ubuntu1 (never noticed that before) which is the default if you use dch to start a new version... is the versioning correct, or do we care for this?

If we don't care, perhaps we should restart the changelog from scratch to eliminate all the previous stuff? <- just a thought, maybe not a good one.

review: Needs Fixing

« Back to merge proposal