Code review comment for lp:~jeffmarcom/opencompute/checkbox-ocp-package-names-update

Revision history for this message
Jeff Lane  (bladernr) wrote :

Still a lot of references to the old packages:
bladernr@klaatu:~/development/checkbox-ocp-package-names-update$ grep checkbox-cli -r *
debian/checkbox-ocp-cli.links:usr/share/man/man1/checkbox.1.gz usr/share/man/man1/checkbox-cli.1.gz
man/checkbox.1:.B /etc/checkbox.d/checkbox-cli.ini
plainbox/plainbox/test-data/xml-exporter/example-data.xml: <package id="92" name="checkbox-cli">
plainbox/plainbox/test-data/xml-exporter/example-data.json: "name": "checkbox-cli",
plainbox/plainbox/test-data/html-exporter/example-data.html: <td class="label">checkbox-cli</td>

bladernr@klaatu:~/development/checkbox-ocp-package-names-update$ grep checkbox-gtk -r *
checkbox_gtk/gtk_interface.py: "checkbox-gtk.ui"))
checkbox_gtk/gtk_interface.py: "checkbox-gtk-head.png")
debian/checkbox-ocp-gtk.links:usr/share/man/man1/checkbox.1.gz usr/share/man/man1/checkbox-gtk.1.gz
man/checkbox.1:.B /etc/checkbox.d/checkbox-gtk.ini
plainbox/plainbox/test-data/xml-exporter/example-data.xml: <package id="95" name="checkbox-gtk">
plainbox/plainbox/test-data/xml-exporter/example-data.json: "name": "checkbox-gtk",
plainbox/plainbox/test-data/html-exporter/example-data.html: <td class="label">checkbox-gtk</td>
po/ga.po:#: ../gtk/checkbox-gtk.ui.h:1 ../qt/checkbox-qt.desktop.in.h:1
po/ga.po:#: ../gtk/checkbox-gtk.ui.h:2 ../checkbox_gtk/gtk_interface.py:561
<SNIT LOTS OF PO FILES>
setup.py: ("share/checkbox/gtk/", ["gtk/checkbox-gtk.ui", "gtk/*.png"]),

anyway, there seem to be a lot of references to the old package names in places like setup.py, debian/* and so forth. Not sure if they'll affect anything (though the man pages are outdated now)

I'm trying a build to see how the package builds now.

review: Needs Fixing

« Back to merge proposal