> Let's land this.
>
> There's a longer story that we talked about on IRC about using PIPE vs DEVNULL
> for stdin but since testing this is expensive and PIPE was tested to work okay
> it should land as is. If possible we should see if using DEVNULL works as it's
> cleaner conceptually
I tested pushing stdin to dev null by changing it to:
stdin=open(os.devnull, 'wb')
This causes the test to always fail as the KVM I/O messages are never properly forwarded to the log file. Instead doing stdin=PIPE works fine.
> Let's land this.
>
> There's a longer story that we talked about on IRC about using PIPE vs DEVNULL
> for stdin but since testing this is expensive and PIPE was tested to work okay
> it should land as is. If possible we should see if using DEVNULL works as it's
> cleaner conceptually
I tested pushing stdin to dev null by changing it to: os.devnull, 'wb')
stdin=open(
This causes the test to always fail as the KVM I/O messages are never properly forwarded to the log file. Instead doing stdin=PIPE works fine.