Code review comment for lp:~jeffmarcom/checkbox/kvm_console_hijack_fix

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Let's land this.

There's a longer story that we talked about on IRC about using PIPE vs DEVNULL for stdin but since testing this is expensive and PIPE was tested to work okay it should land as is. If possible we should see if using DEVNULL works as it's cleaner conceptually

review: Approve

« Back to merge proposal