Code review comment for ~jefferyto/ubuntu/+source/grub2:lp1475620

Revision history for this message
Jeffery To (jefferyto) wrote :

> Hello,
>
> If I understand it right this change already landed upstream (Debian) as part
> of this MR:
>
> https://salsa.debian.org/grub-team/grub/-/merge_requests/33/commits
>
> A package containing your fix is currently in experimental. My expectation is
> that the grub2 will be synced during the Mantic cycle (or merged leaving a
> minimal delta). This will bring your fix to Ubuntu. Therefore I am not sure a
> separate upload to Ubuntu is really worth it, also considering that the
> Importance of LP: #1475620 is Low. What do you think?
>
> Speaking about your MP: you modified an already released d/changelog entry,
> while you should have added a new one (2.06-2ubuntu19). However, again, I am
> not convinced an upload is justified.

Thanks for the review - I wasn't expecting my change to be merged in that MR, that was why I opened this proposal "upstream" (relative to that MR). I think this proposal can be closed/rejected.

« Back to merge proposal