Code review comment for lp:~jefferyto/byobu/openwrt

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hi Jeffrey,

Thanks for contributing this. I'm okay with all of it, except for removing
the -k option from new-window. Why are you doing that?

@DustinKirkland

On Sun, May 26, 2019 at 2:29 PM Jeffery To <email address hidden> wrote:

> Jeffery To has proposed merging lp:~jefferyto/byobu/openwrt into lp:byobu.
>
> Commit message:
> These changes are based on the patches I added to get byobu working on
> OpenWrt (
> https://github.com/openwrt/packages/commit/43c1b1b53cae8800f36d5411e6f0341f7849a200
> ).
>
> Only 2 changes (logo, updates_available) are OpenWrt-specific; the rest
> are more general fixes, e.g. fallbacks when a command-line utility is not
> available, more error handling, etc.
>
> Requested reviews:
> Dustin Kirkland  (kirkland)
>
> For more details, see:
> https://code.launchpad.net/~jefferyto/byobu/openwrt/+merge/367940
> --
> You are requested to review the proposed merge of
> lp:~jefferyto/byobu/openwrt into lp:byobu.
>

« Back to merge proposal