Code review comment for ~jeff250/ubuntu/+source/xorg-server:tearfree

> I went ahead and added a slot for Timo to review this :)

Thanks!

> The upstream patch[1] has this hunk:
>
> hw/xfree86/common/xf86Module.h:
> -#define ABI_VIDEODRV_VERSION SET_ABI_VERSION(25, 3)
> +#define ABI_VIDEODRV_VERSION SET_ABI_VERSION(25, 4)
>
> Your debdiff is not touching that. Precaution, or something else?
>
> But, this is over my head, I don't know if patching xorg like this debdiff has
> other implications.

This change is tricky because the current ABI_VIDEODRV_VERSION of our version (21.1.11) is 25.2, so I don't know if it makes sense to bump it to 25.4, if we don't include the changes from 25.2 to 25.3.

The original author of the upstream merge request did not include this change in his port [1] of the changes to 21.1.x, which my debdiff is based on. However, he may have been faced with the same dilemma.

[1] https://github.com/kerneltoast/xserver/tree/new-tearfree-21.1.5

> I would be much more comfortable if these were in a new release.
>
> I'll note that 21.1.11 was tagged on Jan 16th, 2024, so quite recently, and
> 21.1.10 a month before, so releases are happening.

Yes I would feel more comfortable if these were in a new release as well. :) One of my motivations for submitting this merge request was because the last major release of Xorg's X server (21.1.0) was in 2021. My understanding of their recent releases is that they contain security fixes, minor bug fixes, and only small additions (e.g., PresentWindowDestroyed events).

> Oh, and you should rebase this on top of what is in noble at the moment, which
> is 2:21.1.11-1ubuntu1

Done!