Code review comment for ~jeff250/ubuntu/+source/xorg-server:tearfree
Revision history for this message
| Jeffrey Knockel (jeff250) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Like Simon before me, I don't feel fully comfortable in merging this big diff
> as I have no experience working with the xorg packages.
>
> I pointed out a couple of minor issues with the DEP-3 headers of the patches
> you added, should you need a reference for the syntax of those headers see
> [1]. Also ideally please split the diff in separate commits (one per added
> patch, plus one for the d/changelog changes).
Thanks, I will address these issues.
> Once you find or file an Ubuntu bug describing what you're going to fix here,
> please reference it in the new d/changelog entry using the `LP: #nnnnnn`
> syntax. This way Launchpad will auto-update the bug after the package gets
> uploaded.
There are a number of filed bugs (e.g., [1,2]) addressed by this diff, but my proposed diff won't fix the issue for users by default -- a user must still opt-in to running the modesetting driver in tearfree mode by modifying their xorg.conf file. Is it appropriate to list these bugs and have them automatically closed if the fix is opt-in? (Note that upstream has already accepted a patch [3] to enable tearfree mode by default, i.e., to make it opt-out, but I decided to omit this patch due to its recency and my assumption that it would be easier to get tearfree mode accepted into Ubuntu as opt-in vs. opt-out; however, I can include this patch and make it opt-out if this would be more desirable.)
[1] https:/
[2] https:/
[3] https:/
> A couple of extra questions:
>
> 1. In case you are familiar with Xorg's release schedule, when do you think
> these patches will be part of a new release?
I have no special familiarity with Xorg's release schedule, but my understanding as an outsider is that there is no longer any official "maintainer" of the Xorg X server. This makes me pessimistic that there will be anything but security fixes in future releases for the foreseeable future.
> 2. Is there a Debian bug about the issue?
I did a search and found that [4,5] are likely related, especially [5] as the user reports the issue only occurring after switching from the intel DDX driver to the modesetting one.
[4] https:/
[5] https:/
In general though it doesn't seem as though the debian bugtrackers have the same depth of reporting of the addressed issue as Ubuntu's.
> I'll try to get the attention of somebody more knowledgeable with Xorg.
Thanks, I understand that this is a tricky diff. :)