Code review comment for ~jeff250/ubuntu/+source/xorg-server:tearfree

Revision history for this message
Paride Legovini (paride) wrote :

Like Simon before me, I don't feel fully comfortable in merging this big diff as I have no experience working with the xorg packages.

I pointed out a couple of minor issues with the DEP-3 headers of the patches you added, should you need a reference for the syntax of those headers see [1]. Also ideally please split the diff in separate commits (one per added patch, plus one for the d/changelog changes).

Once you find or file an Ubuntu bug describing what you're going to fix here, please reference it in the new d/changelog entry using the `LP: #nnnnnn` syntax. This way Launchpad will auto-update the bug after the package gets uploaded.

A couple of extra questions:

1. In case you are familiar with Xorg's release schedule, when do you think these patches will be part of a new release?

2. Is there a Debian bug about the issue?

I'll try to get the attention of somebody more knowledgeable with Xorg.

[1] https://dep-team.pages.debian.net/deps/dep3/

« Back to merge proposal