OpenVista/GT.M Integration

Merge lp:~jeff-apple/openvista-gtm-integration/bug359418 into lp:openvista-gtm-integration

  1. bug359418
  2. Merge into mainline
Proposed by jeff.apple
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jeff-apple/openvista-gtm-integration/bug359418
Merge into: lp:openvista-gtm-integration
Diff against target: None lines
To merge this branch: bzr merge lp:~jeff-apple/openvista-gtm-integration/bug359418
Reviewer Review Type Date Requested Status
Jon Tai Approve
Review via email: mp+5457@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jon Tai (jontai) wrote :

Changes look good to me - have we tested this on Cache to ensure that it still works there?

review: Approve
Revision history for this message
jeff.apple (jeff-apple) wrote :

> Changes look good to me - have we tested this on Cache to ensure that it still
> works there?

Do we have a Cache instance that we can destabilize?

Revision history for this message
Jon Tai (jontai) wrote :

> Do we have a Cache instance that we can destabilize?

I can't think of one off-hand, no. Maybe we just merge it now, (possibly pending Joel's review), then worry about regression testing this stuff all at once at the end of Phase I. I've e-mailed Karthick (you should have been CC'd) to make sure this stuff gets regression tested on Cache on both Windows and Linux.

Revision history for this message
jeff.apple (jeff-apple) wrote :

> > Do we have a Cache instance that we can destabilize?
>
> I can't think of one off-hand, no. Maybe we just merge it now, (possibly
> pending Joel's review), then worry about regression testing this stuff all at
> once at the end of Phase I. I've e-mailed Karthick (you should have been
> CC'd) to make sure this stuff gets regression tested on Cache on both Windows
> and Linux.

Maybe sql.medsphere.com could be used. I'm not sure what all that's doing these days.

lp:~jeff-apple/openvista-gtm-integration/bug359418 updated
8. By jeff.apple

Comments added

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mumps/HLCSLNCH.m'
--- mumps/HLCSLNCH.m 2009-04-11 03:29:54 +0000
+++ mumps/HLCSLNCH.m 2009-04-11 03:35:29 +0000
@@ -39,7 +39,7 @@
39 ;-- execute environment check routine if HLQUIT is defined then terminate39 ;-- execute environment check routine if HLQUIT is defined then terminate
40 I HLENV'="" X HLENV G:$D(HLQUIT) STARTQ40 I HLENV'="" X HLENV G:$D(HLQUIT) STARTQ
41 ;Multi-Servers, only enable the link if not OpenM41 ;Multi-Servers, only enable the link if not OpenM
42 I $P(HLPARM4,U,3)="M",$S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS") D G STARTQ42 I $P(HLPARM4,U,3)="M",$$NOTMULTI D G STARTQ
43 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. TCPIP/UCX. You must use the external service to start this LLP."43 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. TCPIP/UCX. You must use the external service to start this LLP."
44 . Q44 . Q
45 ;45 ;
@@ -97,7 +97,7 @@
97 W !,"like to shutdown.",!97 W !,"like to shutdown.",!
98 S DIC="^HLCS(870,",DIC(0)="QEAMZ" D ^DIC K DIC Q:Y<098 S DIC="^HLCS(870,",DIC(0)="QEAMZ" D ^DIC K DIC Q:Y<0
99 S HLDP=+Y,HLDAPP=Y(0,0),HLPARM0=Y(0),HLPARM4=$G(^HLCS(870,HLDP,400))99 S HLDP=+Y,HLDAPP=Y(0,0),HLPARM0=Y(0),HLPARM4=$G(^HLCS(870,HLDP,400))
100 I $P(HLPARM4,U,3)="M",$S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS") D Q100 I $P(HLPARM4,U,3)="M",$$NOTMULTI D Q
101 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. UCX. You must use the external service to disable this LLP."101 . W !,$C(7),"This LLP is a multi-threaded server. It is controlled by external service, i.e. UCX. You must use the external service to disable this LLP."
102 . Q102 . Q
103 ;103 ;
@@ -124,4 +124,7 @@
124 W !,"The job for the "_HLDAPP_" Lower Level Protocol will be shut down."124 W !,"The job for the "_HLDAPP_" Lower Level Protocol will be shut down."
125 Q125 Q
126 ;126 ;
127NOTMULTI() ; Returns 1 if implementation can't run multithreaded listener
128 Q:^%ZOSF("OS")["GT.M" 0
129 Q $S(^%ZOSF("OS")'["OpenM":1,1:$$OS^%ZOSV["VMS")
127STOPQ Q130STOPQ Q
128131
=== modified file 'mumps/HLCSTCP.m'
--- mumps/HLCSTCP.m 2009-04-11 03:29:54 +0000
+++ mumps/HLCSTCP.m 2009-04-11 03:35:29 +0000
@@ -28,8 +28,8 @@
28 . ;couldn't open listener port28 . ;couldn't open listener port
29 . I HLCSFAIL D EXITS("Openfail") Q29 . I HLCSFAIL D EXITS("Openfail") Q
30 ;30 ;
31 ;multi-threaded listener (OpenM)31 ;multi-threaded listener (OpenM or GT.M)
32 I $G(HLTCPCS)="M",^%ZOSF("OS")["OpenM" D Q32 I $G(HLTCPCS)="M",(^%ZOSF("OS")["OpenM")!(^%ZOSF("OS")["GT.M") D Q
33 . D ST1,MON("Listen"),LISTEN^%ZISTCPS(HLTCPORT,"SERVERS^HLCSTCP("""_HLDP_""")")33 . D ST1,MON("Listen"),LISTEN^%ZISTCPS(HLTCPORT,"SERVERS^HLCSTCP("""_HLDP_""")")
34 Q34 Q
35 ;35 ;
@@ -67,7 +67,7 @@
67 I $G(%)="" D ^%ZTER Q67 I $G(%)="" D ^%ZTER Q
68 S (IO,IO(0))="SYS$NET",HLDP=$P(%,"^",2)68 S (IO,IO(0))="SYS$NET",HLDP=$P(%,"^",2)
69 ; **VMS specific code, need to share device**69 ; **VMS specific code, need to share device**
70 O IO:(TCPDEV):60 E D MON("Openfail") Q70 X "O IO:(TCPDEV):60" E D MON("Openfail") Q
71LISTEN ;71LISTEN ;
72 N HLLSTN,HLCSOUT,HLDBACK,HLDBSIZE,HLDREAD,HLDRETR,HLRETRA,HLDWAIT,HLOS,HLTCPADD,HLTCPCS,HLTCPLNK,HLTCPORT,HLTCPRET,HLCSFAIL72 N HLLSTN,HLCSOUT,HLDBACK,HLDBSIZE,HLDREAD,HLDRETR,HLRETRA,HLDWAIT,HLOS,HLTCPADD,HLTCPCS,HLTCPLNK,HLTCPORT,HLTCPRET,HLCSFAIL
73 I '$$INIT D ^%ZTER Q73 I '$$INIT D ^%ZTER Q

Subscribers

People subscribed via source and target branches