Code review comment for lp:~jean-lelievre/purchase-report/product_inventory_warning
Revision history for this message
| Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote | # |
review:
Needs Fixing
(code review)
Hello Jean,
Based on the description of the MP and the module, I would say that the feature is already in OpenERP (OpenERP already provides the qty of product). I think you should add some documentation to explain what OpenERP doesn't do, what your module brings and how to use it.
Please fix PEP8 issues and add the pot file.
I have never seen a module with so much SQL queries. I would be interested to know how it scales.
Otherwise LGTM.
Thanks for your work!