Code review comment for lp:~jdstrand/snap-confine/fix-udev-for-1604

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

>> +const char *static_devices[] = {
>
> I may be missing something but I don't see why this array was lifted from the function that uses it and turned into a global. If it is to remain as global, it should be declared as "static const char *static_devices[]" since it isn't used outside of main.c.

Ah, yes, this should have been moved back down after I made the code simpler.

« Back to merge proposal