lp:~jdstrand/click-reviewers-tools/refactor
- Get this branch:
- bzr branch lp:~jdstrand/click-reviewers-tools/refactor
Branch merges
- James Tait (community): Approve
- Daniel Holbach (community): Approve
-
Diff: 6120 lines (+1198/-1500)53 files modifiedREADME (+1/-1)
bin/click-check-bin-path (+2/-2)
bin/click-check-content-hub (+2/-2)
bin/click-check-desktop (+2/-2)
bin/click-check-framework (+2/-2)
bin/click-check-functional (+2/-2)
bin/click-check-lint (+2/-2)
bin/click-check-online-accounts (+2/-2)
bin/click-check-push-helper (+2/-2)
bin/click-check-scope (+2/-2)
bin/click-check-security (+2/-2)
bin/click-check-skeleton (+2/-2)
bin/click-check-systemd (+2/-2)
bin/click-check-url-dispatcher (+2/-2)
bin/click-review (+4/-4)
bin/click-run-checks (+6/-6)
bin/click-show-files (+15/-18)
bin/detect-package (+15/-0)
bin/download-click (+12/-12)
bin/repack-click (+12/-12)
bin/unpack-package (+3/-3)
check-names.list (+0/-3)
clickreviews/common.py (+514/-0)
clickreviews/cr_bin_path.py (+14/-8)
clickreviews/cr_common.py (+35/-468)
clickreviews/cr_content_hub.py (+8/-0)
clickreviews/cr_desktop.py (+61/-0)
clickreviews/cr_framework.py (+13/-7)
clickreviews/cr_functional.py (+11/-0)
clickreviews/cr_lint.py (+66/-100)
clickreviews/cr_online_accounts.py (+20/-0)
clickreviews/cr_push_helper.py (+12/-0)
clickreviews/cr_scope.py (+6/-0)
clickreviews/cr_security.py (+94/-92)
clickreviews/cr_skeleton.py (+12/-0)
clickreviews/cr_systemd.py (+21/-18)
clickreviews/cr_tests.py (+24/-63)
clickreviews/cr_url_dispatcher.py (+12/-0)
clickreviews/modules.py (+5/-5)
clickreviews/tests/test_cr_bin_path.py (+4/-1)
clickreviews/tests/test_cr_content_hub.py (+0/-13)
clickreviews/tests/test_cr_desktop.py (+0/-14)
clickreviews/tests/test_cr_framework.py (+4/-1)
clickreviews/tests/test_cr_lint.py (+74/-383)
clickreviews/tests/test_cr_online_accounts.py (+0/-12)
clickreviews/tests/test_cr_push_helper.py (+0/-10)
clickreviews/tests/test_cr_scope.py (+0/-12)
clickreviews/tests/test_cr_security.py (+74/-187)
clickreviews/tests/test_cr_systemd.py (+3/-0)
clickreviews/tests/test_cr_url_dispatcher.py (+0/-12)
clickreviews/tests/test_modules.py (+7/-7)
clickreviews/tests/utils.py (+4/-2)
debian/changelog (+6/-0)
Related source package recipes
Branch information
Recent revisions
- 581. By Jamie Strandboge
-
clickreviews/
cr_lint. py: don't run check_contents_ for_hardcoded_ paths() on
snap v2 - 580. By Jamie Strandboge
-
clickreviews/
cr_security. py: clarify logic of package detection in two tests - 579. By Jamie Strandboge
-
use self.is_click, etc instead of self._pkgfmt_
version( )
fix some 16.04isms in clickreviews/cr_security. py - 578. By Jamie Strandboge
-
clickreviews/
cr_lint. py:
- make sure md5sums test is run with clicks
- use self.is_click instead of 'self._pkgfmt_ type() == "click"'
- only run check_pkgname() on click - 573. By Jamie Strandboge
-
- rename bin/unpack-click as bin/unpack-package
- add common.py
+ refactor non-click and non-snap1 bits from cr_common.py
+ add proper package detection API and variables for click, snap1 and snap2
- clickreviews/cr_* (and tests)
+ adjust for common.py
+ use new detection variables and only run on click and snap1 snaps
+ cleanup cr_common.py to remove snap2 support (will be added in a later
commit)
- clickreviews/cr_tests. py:
+ remove snap2 support (will be added in a later commit)
+ add detect_package support
+ various cleanups for refactoring
- adjust bin/*, clickreviews/* and clickreviews/tests/* to use common instead
of cr_common
- bin/click-run-checks, clickreviews/ modules. py: don't assume 'click' in
variable names, etc
- pull existing snap v2 tests out of cr_*
- add bin/detect-package
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:click-reviewers-tools
