Canonical Click Reviewers tools (obsolete)

Code review comment for lp:~jdstrand/click-reviewers-tools/lp1346481

  1. lp1346481
  2. Merge into trunk
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

> 312 + if 'push-helper' not in self.manifest['hooks'][app]:
> 313 + # self._add_result(t, n, s)
> 314 + continue
>
> Why the commenting out?
> (the same a few lines lower)
>
Ah, these should have been omitted from the commit. Fixed. (There is no reason to run this test if the app doesn't specify a push-helper hook).

>
> LGTM otherwise.

Thanks!

« Back to merge proposal