Code review comment for lp:~jdstrand/click-reviewers-tools/crt.cleanup

No conflicts. Have you pushed all changes?

======================================================================
ERROR: test_check_snappy_readme_md (test_cr_lint.TestClickReviewLint)
Test check_snappy_readme_md()
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/tests/test_cr_lint.py", line 1500, in test_check_snappy_readme_md
    c.check_snappy_readme_md()
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/cr_lint.py", line 1137, in check_snappy_readme_md
    if is_squashfs(self.pkg_filename):
NameError: name 'is_squashfs' is not defined

======================================================================
ERROR: test_check_snappy_readme_md_bad (test_cr_lint.TestClickReviewLint)
Test check_snappy_readme_md() - short
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/tests/test_cr_lint.py", line 1526, in test_check_snappy_readme_md_bad
    c.check_snappy_readme_md()
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/cr_lint.py", line 1137, in check_snappy_readme_md
    if is_squashfs(self.pkg_filename):
NameError: name 'is_squashfs' is not defined

======================================================================
ERROR: test_check_snappy_readme_md_bad2 (test_cr_lint.TestClickReviewLint)
Test check_snappy_readme_md() - missing
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/tests/test_cr_lint.py", line 1537, in test_check_snappy_readme_md_bad2
    c.check_snappy_readme_md()
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/cr_lint.py", line 1137, in check_snappy_readme_md
    if is_squashfs(self.pkg_filename):
NameError: name 'is_squashfs' is not defined

======================================================================
ERROR: test_check_snappy_readme_md_squashfs (test_cr_lint.TestClickReviewLint)
Test check_snappy_readme_md() - squashfs file
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/daniel/dev/click/click-reviewers-tools/clickreviews/tests/test_cr_lint.py", line 1507, in test_check_snappy_readme_md_squashfs
    with patch("clickreviews.cr_lint.is_squashfs") as mock_is_squashfs:
  File "/usr/lib/python3.5/unittest/mock.py", line 1221, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python3.5/unittest/mock.py", line 1195, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <module 'clickreviews.cr_lint' from '/home/daniel/dev/click/click-reviewers-tools/clickreviews/cr_lint.py'> does not have the attribute 'is_squashfs'

----------------------------------------------------------------------
Ran 817 tests in 7.082s

FAILED (errors=4)
added:
  bin/detect-package
  bin/snap-check-lint
  bin/snap-check-skeleton
  clickreviews/common.py
  clickreviews/sr_common.py
  clickreviews/sr_lint.py
  clickreviews/sr_skeleton.py
  clickreviews/sr_tests.py
  clickreviews/tests/test_bbb_example_sr_skeleton.py
  clickreviews/tests/test_sr_lint.py
renamed:
  bin/unpack-click => bin/unpack-package
modified:
  README
  bin/click-check-bin-path
  bin/click-check-content-hub
  bin/click-check-desktop
  bin/click-check-framework
  bin/click-check-functional
  bin/click-check-lint
  bin/click-check-online-accounts
  bin/click-check-push-helper
  bin/click-check-scope
  bin/click-check-security
  bin/click-check-skeleton
  bin/click-check-systemd
  bin/click-check-url-dispatcher
  bin/click-review
  bin/click-run-checks
  bin/click-show-files
  bin/download-click
  bin/repack-click
  check-names.list
  clickreviews/cr_bin_path.py
  clickreviews/cr_common.py
  clickreviews/cr_content_hub.py
  clickreviews/cr_desktop.py
  clickreviews/cr_framework.py
  clickreviews/cr_functional.py
  clickreviews/cr_lint.py
  clickreviews/cr_online_accounts.py
  clickreviews/cr_push_helper.py
  clickreviews/cr_scope.py
  clickreviews/cr_security.py
  clickreviews/cr_skeleton.py
  clickreviews/cr_systemd.py
  clickreviews/cr_tests.py
  clickreviews/cr_url_dispatcher.py
  clickreviews/modules.py
  clickreviews/tests/test_cr_bin_path.py
  clickreviews/tests/test_cr_desktop.py
  clickreviews/tests/test_cr_framework.py
  clickreviews/tests/test_cr_lint.py
  clickreviews/tests/test_cr_security.py
  clickreviews/tests/test_cr_systemd.py
  clickreviews/tests/test_modules.py
  clickreviews/tests/utils.py
  setup.py
  bin/unpack-package
unknown:
  myapp.mo
  bin/clickreviews@
pending merges:
  Jamie Strandboge 2016-02-08 update comment from last commit
    Jamie Strandboge 2016-02-08 add type checking for skills
    Jamie Strandboge 2016-02-08 add toplevel uses tests
    Jamie Strandboge 2016-02-08 clickreviews/tests/test_sr_lint.py: remo...
    Jamie Strandboge 2016-02-05 move TODO items to the end
    Jamie Strandboge 2016-02-05 add socket tests
    Jamie Strandboge 2016-02-05 add stop-timeout tests
    Jamie Strandboge 2016-02-05 add daemon options tests
    Jamie Strandboge 2016-02-05 add ports checks
    Jamie Strandboge 2016-02-04 add bus-name checks
    Jamie Strandboge 2016-02-04 implement restart-condition tests
    Jamie Strandboge 2016-02-04 add tests for stop and poststop
    Jamie Strandboge 2016-02-04 implement check_apps_daemon()
    Jamie Strandboge 2016-02-04 pep8 for last commit
    Jamie Strandboge 2016-02-04 clickreviews/sr_lint.py:
    Jamie Strandboge 2016-02-03 add some apps tests to sr_lint.py
    Jamie Strandboge 2016-02-03 clickreviews/sr_lint.py:
    Jamie Strandboge 2016-02-03 add check_description for snap.yaml
    Jamie Strandboge 2016-02-02 clickreviews/common.py:
    Jamie Strandboge 2016-02-02 * bin/click-show-files:
    Jamie Strandboge 2016-02-01 use lint-snap-v2 and skeleton-snap-v2 in...
    Jamie Strandboge 2016-02-01 update modules.py to find sr_* modules
    Jamie Strandboge 2016-02-01 add sr lint tests
    Jamie Strandboge 2016-02-01 clickreviews/common.py: copy functions f...
    Jamie Strandboge 2016-02-01 use 'modules' instead of 'cr_modules'
    Jamie Strandboge 2016-02-01 create a Review object in clickreviews/c...
    Jamie Strandboge 2016-02-01 pep8 fixes for last commit
    Jamie Strandboge 2016-02-01 move all utility functions from cr_commo...
    Jamie Strandboge 2016-02-01 add clickreviews/cr_common.py and move s...
    Jamie Strandboge 2016-02-01 [merge] merge from trunk