Code review comment for lp:~jderose/ubuntu/saucy/couchdb/1.4.0

Revision history for this message
Chad Miller (cmiller) wrote :

Jason, also pay attention to lintian messages. Fix these "E" at least for next upload. Maybe you can ignore the init.d ones, assuming you Depend on upstart.

W: couchdb-common: debian-changelog-line-too-long line 14
W: couchdb-common: embedded-javascript-library usr/share/couchdb/www/docs/_static/jquery.js
W: couchdb-common: embedded-javascript-library usr/share/couchdb/www/docs/_static/underscore.js
W: couchdb-common: embedded-javascript-library usr/share/couchdb/www/script/jquery.form.js
W: couchdb-common: embedded-javascript-library usr/share/couchdb/www/script/jquery.js
W: couchdb-common: executable-not-elf-or-script usr/share/couchdb/server/main.js
W: couchdb-common: executable-not-elf-or-script usr/share/couchdb/server/main-coffee.js
W: couchdb-bin: debian-changelog-line-too-long line 14
W: couchdb-bin: virtual-package-depends-without-real-package-depends depends: erlang-abi-15.b
E: couchdb-bin: package-contains-info-dir-file usr/share/info/dir.gz
W: couchdb-bin: binary-without-manpage usr/bin/couch-config
E: couchdb-bin: non-empty-dependency_libs-in-la-file usr/lib/i386-linux-gnu/couchdb/erlang/lib/couch-1.4.0/priv/lib/couch_ejson_compare.la
E: couchdb-bin: non-empty-dependency_libs-in-la-file usr/lib/i386-linux-gnu/couchdb/erlang/lib/couch-1.4.0/priv/lib/couch_icu_driver.la
E: couchdb-bin: non-empty-dependency_libs-in-la-file usr/lib/i386-linux-gnu/couchdb/erlang/lib/ejson-0.1.0/priv/ejson.la
E: couchdb-bin: non-empty-dependency_libs-in-la-file usr/lib/i386-linux-gnu/couchdb/erlang/lib/snappy-1.0.5/priv/snappy_nif.la
W: couchdb: debian-changelog-line-too-long line 14
E: couchdb: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/couchdb
W: couchdb: init.d-script-not-marked-as-conffile etc/init.d/couchdb
E: couchdb: init.d-script-not-included-in-package etc/init.d/couchdb

« Back to merge proposal