Code review comment for lp:~jderose/filestore/ensuredir

Revision history for this message
Paul Hummer (rockstar) wrote :

's' is not a very good name for a variable. Sure, the scope is limited, but it looks like you've also got a 'd' variable nearby. I would discourage that even in a language where the variable length might matter (like client-side javascript). You might want to re-think that.

...of course, I'm only a "community" vote.

review: Needs Fixing

« Back to merge proposal