Merge lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14824 |
Proposed branch: | lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff |
Merge into: | lp:launchpad |
Diff against target: |
81 lines (+64/-2) 1 file modified
lib/lp/registry/templates/product-sharing.pt (+64/-2) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+93501@code.launchpad.net |
Commit message
[r=wallyworld][bug=933792,933794][incr] Adds placeholder HTML for +sharing UI elements
Description of the change
Summary
=======
This branch just contains some placeholders for the thus far agreed upon
elements of the +sharing page's UI.
Implementation
==============
This branch just puts in the static, empty table and the side portlet
summarizing sharing data without the view populating the numbers.
There is other code in work to populate this data, but some of the data to
drive it is still in flux and I would rather get this landed to prevent
conflicts and blocking as purple team continues its work.
Tests
=====
There are no new tests; this branch just lands unchanging static HTML in some
templates, so there are no new moving parts to test.
QA
==
Make sure there's an empty table and side portlet on
qastaging.
Lint
====
This branch is lint free.
Good to land. I'm sure stuff will change as we progress but it's good to keep things moving by landing what we have.