Code review comment for lp:~jcsackett/launchpad/set-question-message-visibility

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-03-23 03:46 PM, j.c.sackett wrote:
>> Looking at the diff, I see you are un-exporting messages. Is that deliberate?
>
> Yes, per my comment to Curtis in this MP. There are some security concerns when exposing the various message objects and it's unnecessary to export them in order for the setCommentVisibility method to work.
>
>> Also, I've never seen endInteraction used before. What does it do?
>
> It kills the existing _thread.interaction data so you can start a new one. Without it, calling up new lplib instances in the test can run into an error about establishing _thread.interaction while the previous one is present. This is particularly common with the anonymous login case. I believe Salgado was the one who pointed it out to me for some other, similar test cases a few months ago.

It appears to be the underlying implementation of logout. logout is
much more familiar to everyone. Is there a reason you're not using it?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2KUYcACgkQ0F+nu1YWqI3q9QCfZOnXzryg25OlfKSqLCDaijdK
ilIAnRNr12aZtxTKxglRKdykIqydJbQd
=WNC7
-----END PGP SIGNATURE-----