Code review comment for lp:~jcsackett/launchpad/progressively-enhanced-banners

> The changes look good, but this branch is missing tests.
> lib/lp/app/browsers/tests/test_formatters.py
> was not updated. The renaming of public_private_css => global_css should have
> broken the existing tests. I expect to see tests for the new rules.
>
> I am surprised that the change of .beta-banner =>.global-notification in
> lib/lp/app/javascript/banners/beta-notification.js
> did not break a js test because this is a contract between the js and css.

This is the peril of making coffee after invoking bzr lp-propose; I never noticed my test changes hadn't been committed. They address the points above.

> The two new properties in lib/lp/services/webapp/publisher.py need tests.

Yes they do, good call. I have created tests for the privacy and beta_features attribute.