The changes look good, but this branch is missing tests.
lib/lp/app/browsers/tests/test_formatters.py
was not updated. The renaming of public_private_css => global_css should have broken the existing tests. I expect to see tests for the new rules.
I am surprised that the change of .beta-banner =>.global-notification in
lib/lp/app/javascript/banners/beta-notification.js
did not break a js test because this is a contract between the js and css.
The two new properties in lib/lp/services/webapp/publisher.py need tests.
The changes look good, but this branch is missing tests. lp/app/ browsers/ tests/test_ formatters. py
lib/
was not updated. The renaming of public_private_css => global_css should have broken the existing tests. I expect to see tests for the new rules.
I am surprised that the change of .beta-banner =>.global- notification in lp/app/ javascript/ banners/ beta-notificati on.js
lib/
did not break a js test because this is a contract between the js and css.
The two new properties in lib/lp/ services/ webapp/ publisher. py need tests.