Code review comment for lp:~jcsackett/launchpad/mergeproposal-status-icon-589584

Revision history for this message
j.c.sackett (jcsackett) wrote :

Gavin--

I've pushed up changes; in the end I basically had to just fix my diff, since the coloration issue won't work with a span inside the anchor.

I also had to fix up the javascript related to the spinner and color changes as status is changed; you should see the change in the diff, but essentially I updated it to look for an anchor tag where it was looking for spans.

« Back to merge proposal